poyrazavsever/neta
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(ui): enforce poyraz button standards

Browse Source
This commit is contained in:
poyrazavsever
2026-07-17 22:14:09 +03:00
parent bf10eb0fb0
commit 236f136a6f
9 changed files with 151 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/invite/[token]/page.tsx
+1 -1
View File
@@ -77,7 +77,7 @@ export default async function InvitationPage({
<p className="text-xs text-muted-foreground">En az 8 karakter kullan.</p>
</div>
</div>
<SubmitButton formAction={acceptInvitation} className="h-11 w-full" pendingText="Hesap oluşturuluyor...">
<SubmitButton size="lg" formAction={acceptInvitation} className="w-full" pendingText="Hesap oluşturuluyor...">
Portal hesabını oluştur
</SubmitButton>
</form>
app/login/page.tsx
+1 -1
View File
@@ -75,7 +75,7 @@ export default async function LoginPage({
</div>
</div>
<SubmitButton formAction={login} className="h-11 w-full gap-2" pendingText="Giriş yapılıyor...">
<SubmitButton size="lg" formAction={login} className="w-full gap-2" pendingText="Giriş yapılıyor...">
<LogIn className="h-4 w-4" />
Giriş yap
</SubmitButton>
app/register/page.tsx
+1 -1
View File
@@ -79,7 +79,7 @@ export default async function RegisterPage({
</div>
</div>
<SubmitButton formAction={signup} className="h-11 w-full gap-2" pendingText="Oluşturuluyor...">
<SubmitButton size="lg" formAction={signup} className="w-full gap-2" pendingText="Oluşturuluyor...">
<UserPlus className="h-4 w-4" />
Admin hesabını oluştur
</SubmitButton>
components/auth/submit-button.tsx
+13 -2
View File
@@ -4,20 +4,31 @@ import { useFormStatus } from "react-dom";
import { Button } from "poyraz-ui/atoms";
import React from "react";
interface SubmitButtonProps extends React.ComponentProps<typeof Button> {
interface SubmitButtonProps
extends Omit<React.ComponentProps<typeof Button>, "effect" | "variant"> {
pendingText?: string;
variant?: "default" | "secondary";
}
export function SubmitButton({
children,
pendingText,
type = "submit",
variant = "default",
...props
}: SubmitButtonProps) {
const { pending } = useFormStatus();
return (
<Button type={type} disabled={pending} loading={pending} aria-busy={pending} {...props}>
<Button
type={type}
disabled={pending}
loading={pending}
aria-busy={pending}
{...props}
variant={variant}
effect="shine"
>
{pending ? (
<>
{pendingText || children}
components/layout/app-shell.tsx
+7 -5
View File
@@ -4,6 +4,7 @@ import { signOut } from "@/app/login/actions";
import { ColorModeSync } from "@/components/theme/color-mode-sync";
import type { ColorMode } from "@/lib/color-mode";
import {
Button,
Card,
CardContent,
Typography,
@@ -308,10 +309,11 @@ function AccountMenu({ user, settingsHref }: { user: ShellUser; settingsHref: st
return (
<DropdownMenu>
<DropdownMenuTrigger asChild>
<button
<Button effect="shine"
type="button"
variant="secondary"
aria-label={`${user.displayName} için hesap menüsünü aç`}
className="group flex w-full items-center gap-2 rounded-md border border-transparent p-1.5 text-left outline-none transition-[color,background-color,border-color] hover:border-border hover:bg-accent focus-visible:ring-2 focus-visible:ring-focus-ring data-[state=open]:border-border data-[state=open]:bg-accent"
className="group h-auto min-h-10 w-full justify-start p-1.5 text-left"
>
<SidebarUserProfile
className="min-w-0 flex-1"
@@ -324,7 +326,7 @@ function AccountMenu({ user, settingsHref }: { user: ShellUser; settingsHref: st
className="h-4 w-4 shrink-0 text-muted-foreground transition-transform group-data-[state=open]:rotate-180"
aria-hidden="true"
/>
</button>
</Button>
</DropdownMenuTrigger>
<DropdownMenuContent
align="start"
@@ -355,10 +357,10 @@ function AccountMenu({ user, settingsHref }: { user: ShellUser; settingsHref: st
asChild
className="text-destructive focus:text-destructive data-[highlighted]:text-destructive"
>
<button type="submit" className="w-full gap-2 text-left">
<Button effect="shine" type="submit" variant="secondary" size="sm" className="w-full justify-start gap-2 text-left text-destructive">
<LogOut className="h-4 w-4 shrink-0" aria-hidden="true" />
<span>Çıkış yap</span>
</button>
</Button>
</DropdownMenuItem>
</form>
</DropdownMenuContent>
components/system/destructive-confirmation.tsx
+3 -2
View File
@@ -41,13 +41,14 @@ export function DestructiveConfirmation({
</DialogHeader>
<DialogFooter>
<DialogClose asChild>
<Button type="button" variant="outline" disabled={loading}>
<Button effect="shine" type="button" variant="secondary" disabled={loading}>
{cancelLabel}
</Button>
</DialogClose>
<Button
effect="shine"
type="button"
variant="destructive"
variant="default"
loading={loading}
aria-busy={loading}
onClick={onConfirm}
components/system/feedback-state.tsx
+1 -1
View File
@@ -62,7 +62,7 @@ export function LoadingState({ label = "İçerik yükleniyor" }: { label?: strin
export function RetryAction({ onClick }: { onClick: () => void }) {
return (
<Button type="button" variant="outline" size="sm" onClick={onClick}>
<Button effect="shine" type="button" variant="secondary" size="sm" onClick={onClick}>
Yeniden dene
</Button>
);
components/ui/pending-submit-button.tsx
+8 -1
View File
@@ -7,10 +7,14 @@ import { useFormStatus } from "react-dom";
import { cn } from "@/lib/utils";
type PendingSubmitButtonProps = ComponentProps<typeof Button> & {
type PendingSubmitButtonProps = Omit<
ComponentProps<typeof Button>,
"effect" | "variant"
> & {
idleIcon?: ReactNode;
pendingIcon?: ReactNode;
pendingChildren?: ReactNode;
variant?: "default" | "secondary";
};
export function PendingSubmitButton({
@@ -21,6 +25,7 @@ export function PendingSubmitButton({
pendingChildren,
pendingIcon,
type = "submit",
variant = "default",
...props
}: PendingSubmitButtonProps) {
const { pending } = useFormStatus();
@@ -36,6 +41,8 @@ export function PendingSubmitButton({
aria-busy={pending}
loading={pending && !pendingIcon}
className={cn(className)}
variant={variant}
effect="shine"
>
{icon}
{pending ? pendingChildren ?? children : children}
scripts/phase4-ui-boundary.mjs
+116
View File
@@ -1,6 +1,7 @@
import assert from "node:assert/strict";
import fs from "node:fs";
import path from "node:path";
import ts from "typescript";
const repoRoot = process.cwd();
const packageJson = JSON.parse(fs.readFileSync(path.join(repoRoot, "package.json"), "utf8"));
@@ -164,6 +165,8 @@ for (const sliderBehavior of [
"snap-mandatory",
"overflow-x-auto",
"scrollBy",
"[scrollbar-width:none]",
"[&::-webkit-scrollbar]:hidden",
'event.key === "ArrowLeft"',
'event.key === "ArrowRight"',
]) {
@@ -173,6 +176,45 @@ for (const sliderBehavior of [
);
}
const pageHeaderFiles = [
"app/(dashboard)/dashboard-client.tsx",
"app/(dashboard)/analytics/analytics-client.tsx",
"app/(dashboard)/calendar/calendar-client.tsx",
"app/(dashboard)/clients/clients-client.tsx",
"app/(dashboard)/clients/[id]/client-detail-client.tsx",
"app/(dashboard)/finance/finance-client.tsx",
"app/(dashboard)/journal/journal-client.tsx",
"app/(dashboard)/projects/projects-client.tsx",
"app/(dashboard)/projects/[id]/project-detail-client.tsx",
"app/(dashboard)/tasks/tasks-client.tsx",
"app/(dashboard)/settings/page.tsx",
"app/(dashboard)/business/invoices/invoices-client.tsx",
"app/(dashboard)/business/proposals/proposals-client.tsx",
"app/(dashboard)/business/subscriptions/subscriptions-client.tsx",
"app/(dashboard)/chat/page.tsx",
"app/portal/page.tsx",
"app/portal/projects/page.tsx",
"app/portal/projects/[id]/portal-project-client.tsx",
"app/portal/tasks/page.tsx",
"app/portal/revisions/page.tsx",
];
for (const pageHeaderFile of pageHeaderFiles) {
const content = fs.readFileSync(path.join(repoRoot, pageHeaderFile), "utf8");
assert.doesNotMatch(
content,
/<\/h1>\s*(?:\{[^\n]*&&\s*)?<p\b[^>]*text-muted-foreground/,
`${pageHeaderFile} must not render a description directly below its page title`,
);
}
assert.doesNotMatch(
fs.readFileSync(
path.join(repoRoot, "app/(dashboard)/projects/[id]/project-detail-client.tsx"),
"utf8",
),
/project\.description\s*\|\|/,
"Project detail header must not render the project description below its title",
);
const allowedLocalUiFiles = new Set([
"pending-link.tsx",
"pending-submit-button.tsx",
@@ -221,6 +263,80 @@ function walk(targetPath) {
});
}
const buttonViolations = ["app", "components"]
.flatMap(walk)
.filter((filePath) => filePath.endsWith(".tsx"))
.flatMap((filePath) => {
const content = fs.readFileSync(filePath, "utf8");
const relativePath = path.relative(repoRoot, filePath);
const sourceFile = ts.createSourceFile(
filePath,
content,
ts.ScriptTarget.Latest,
true,
ts.ScriptKind.TSX,
);
const violations = [];
let hasPoyrazButtonImport = false;
const buttonNodes = [];
function visit(node) {
if (
ts.isImportDeclaration(node) &&
node.moduleSpecifier.text === "poyraz-ui/atoms" &&
node.importClause?.namedBindings &&
ts.isNamedImports(node.importClause.namedBindings)
) {
hasPoyrazButtonImport ||= node.importClause.namedBindings.elements.some(
(element) => element.name.text === "Button",
);
}
if (ts.isJsxOpeningElement(node) || ts.isJsxSelfClosingElement(node)) {
const tagName = node.tagName.getText(sourceFile);
if (tagName === "button") {
const line = sourceFile.getLineAndCharacterOfPosition(node.getStart(sourceFile)).line + 1;
violations.push(`${relativePath}:${line}: native button must use Poyraz Button`);
}
if (tagName === "Button") buttonNodes.push(node);
}
ts.forEachChild(node, visit);
}
visit(sourceFile);
if (buttonNodes.length > 0 && !hasPoyrazButtonImport) {
violations.push(`${relativePath}: Button must be imported from poyraz-ui/atoms`);
}
for (const node of buttonNodes) {
const line = sourceFile.getLineAndCharacterOfPosition(node.getStart(sourceFile)).line + 1;
const attributes = node.attributes.properties.filter(ts.isJsxAttribute);
const effect = attributes.find((attribute) => attribute.name.getText(sourceFile) === "effect");
const variant = attributes.find((attribute) => attribute.name.getText(sourceFile) === "variant");
const variantText = variant?.getText(sourceFile) ?? "";
if (effect?.getText(sourceFile) !== 'effect="shine"') {
violations.push(`${relativePath}:${line}: Button must use effect="shine"`);
}
if (!variant || /outline|ghost|destructive|soft|glass|link/.test(variantText)) {
violations.push(
`${relativePath}:${line}: Button variant must be default or secondary`,
);
}
if (/bg-indigo|border-indigo|text-indigo/.test(node.getText(sourceFile))) {
violations.push(`${relativePath}:${line}: Button must not override Poyraz variant colors`);
}
}
return violations;
});
assert.deepEqual(
buttonViolations,
[],
`Poyraz Button boundary violations:\n${buttonViolations.join("\n")}`,
);
const violations = ["app", "components"]
.flatMap(walk)
.flatMap((filePath) => {